[PATCH] D68008: [Attributor] Use abstract call sites to determine associated arguments

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert marked an inline comment as done.
jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:179-189
+    for (unsigned u = 0, e = ACS.getNumArgOperands(); u < e; u++) {
+
+      // Test if the underlying call site operand is argument number u of the
+      // callback callee.
+      if (ACS.getCallArgOperandNo(u) != ArgNo)
+        continue;
+
----------------
uenoku wrote:
> I couldn't understand this part. Is it sound to return an argument of the callback callee we have found first?
You are right. I'll add code to ensure we do not return a callback callee argument if there is not a unique one mapped to the requested call site argument.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68008/new/

https://reviews.llvm.org/D68008