[PATCH] D69546: [SanitizerCommon] Print the current value of options when printing out help.

[Dan Liew via Phabricator via llvm-commits]

delcypher added a comment.

In D69546#1731024 <https://reviews.llvm.org/D69546#1731024>, @yln wrote:

> In D69546#1730860 <https://reviews.llvm.org/D69546#1730860>, @delcypher wrote:
>
> > I thought that might be ambiguous (Is `...` part of the string or is the string truncated?).
>
>
> Do you anticipate this to be an issue?  My feeling is that truncation would only happen with file paths?!  I have a slight preference towards the other because it seems simpler (simple, not easy), but I am not blocking on this.


Well visually `...` is very similar to `..` which actually has a meaning in paths. In the current implementation truncation is very unlikely to happen because we allocate a much larger buffer to store strings representing the current value.

That said. I'm pretty happy with the implementation now. Only in extreme cases will truncation happen and we handle it is a way that is unambiguous and hopefully robust.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69546/new/

https://reviews.llvm.org/D69546