[PATCH] D69868: Allow "callbr" to return non-void values

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 7 14:45:18 PST 2019


nickdesaulniers added inline comments.


================
Comment at: llvm/docs/LangRef.rst:7156
 
+Outputs of a '``callbr``' instruction are valid only on the '``normal``' path.
+Use of outputs on the '``other``' path(s) results in :ref:`poison values
----------------
Rather than the distinction between "normal" and "other," can we use the terms "fallthrough" and "indirect?"


================
Comment at: llvm/docs/LangRef.rst:7159
+<poisonvalues>`. Care should be taken if the '``normal``' block is also listed
+in the '``other``' blocks. The outputs may or may not result in :ref:`poison
+values <poisonvalues>` depending on the behavior of the inline assembly.
----------------
I assume that's the WIP part? Otherwise there's nothing else here that explicitly adds poison from what I can tell.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69868/new/

https://reviews.llvm.org/D69868





More information about the llvm-commits mailing list