[PATCH] D69684: [debuginfo-tests] Don't look for Python 3 if we already have it

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

I'm running into an issue running clang tests that can be traced back to https://reviews.llvm.org/D68708.

I'm configuring with debuginfo-tests enabled and python2.7 as the python executable, but with a python3 also installed. The end result is that `tools/clang/test/lit.site.cfg.py` defines `config.python_executable = ""`, which results in the weirdest of errors. That file is expanded from `clang/test/lit.site.cfg.py.in` where it is `config.python_executable = "@PYTHON_EXECUTABLE@"`. I git-bisected it to D68708 <https://reviews.llvm.org/D68708>, which seems to make sense. I don't claim to fully understand what is going on here, but I believe that `unset`ing `PYTHON_EXECUTABLE` is dangerous. Could we initialize a PYTHON3_EXECUTABLE variable here, or even better, just error out if `PYTHON_EXECUTABLE` is not python 3? Which users/bot are we supporting with this code?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69684/new/

https://reviews.llvm.org/D69684