[PATCH] D69751: [AsmWritter] Fixed "null check after dereferencing" warning

James Y Knight via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 7 10:47:16 PST 2019


jyknight added a comment.

In D69751#1737360 <https://reviews.llvm.org/D69751#1737360>, @xbolva00 wrote:

> >>   It should never be required in normal circumstances, but this function can also be used while debugging, where that would be convenient.
>
> Not sure how it can be used currently, maybe with a big luck, since there is null pointer dereferencing.
>
> I am gonna commit this.


It surely cannot currently. That's why I was saying it _would be nice_ for it to be fixed so that if you have a block which is unattached, you can actually print it in a debugging situation, rather than crashing. That was the original intent, and it's certainly not critical, but it still makes sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69751/new/

https://reviews.llvm.org/D69751





More information about the llvm-commits mailing list