[PATCH] D66746: [LiveDebugValues] Omit entry values for DBG_VALUEs with pre-existing expressions

[David Stenberg via Phabricator via llvm-commits]

dstenb abandoned this revision.
dstenb added a comment.

Sorry for the delay!

The DW_OP_LLVM_entry_value operation has now been introduced, and that allows for DW_OP_entry_value operations with blocks larger than one byte to be expressed. However, the DW_OP_LLVM_entry_value operation can currently only wrap one operation in the DIExpression (there are some things missing in DwarfDebug and DwarfExpression for allowing more), so we'd still see the crash that this patch addresses.

However, we do not really want to emit an entry value here, as the caller's parameter value has been propagated into the callee. I think that "omit entry values if the caller's parameter value has been propagated into the callee" is the condition that I really want check here. I have created a new patch that attempts to address that: D69889 <https://reviews.llvm.org/D69889>. I will abandon this revision, and we can then revisit it later on if needed.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66746/new/

https://reviews.llvm.org/D66746