[PATCH] D69889: [DebugInfo] Avoid creating entry values for clobbered registers

David Stenberg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 7 10:10:50 PST 2019


dstenb marked 3 inline comments as done.
dstenb added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveDebugValues.cpp:1331
+
     if (MI.isDebugValue() && IsUnmodifiedFuncParam(MI) &&
         !MI.isIndirectDebugValue() && IsRegOtherThanSPAndFP(MI.getOperand(0)) &&
----------------
djtodoro wrote:
> Maybe all of this can go in a helper as well. I think that should simplify the code here.
Yes, good idea! I put that refactoring in a parent patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69889/new/

https://reviews.llvm.org/D69889





More information about the llvm-commits mailing list