[PATCH] D69740: [profile] Support counter relocation at runtime
David Li via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 7 08:27:57 PST 2019
davidxl added a comment.
If the runtime/size overhead is acceptable, I prefer this simpler version of implementation. We can always document the improvement possibility in the source and enhance it later if needed.
================
Comment at: compiler-rt/lib/profile/InstrProfilingFile.c:235
+ /* Get the size of the profile on disk. */
+ if (getProfileFileSizeForMerging(ProfileFile, &ProfileFileSize) == -1)
+ return -1;
----------------
Can you split the refactoring change into a separate patch to minimize diff here?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69740/new/
https://reviews.llvm.org/D69740
More information about the llvm-commits
mailing list