[PATCH] D69886: [DebugInfo] Support for DW_OP_implicit_pointer (CodeGen phase)

[Alok Kumar Sharma via Phabricator via llvm-commits]

alok marked 5 inline comments as done.
alok added inline comments.


================
Comment at: llvm/test/DebugInfo/dwarfdump-implicit_pointer_instcomb.ll:38
+  call void @llvm.dbg.value(metadata !32, metadata !17, metadata !DIExpression(DW_OP_implicit_pointer, 0)), !dbg !36
+  store volatile i32 4, i32* @gvar, align 4, !dbg !38, !tbaa !20
+  call void @llvm.dbg.value(metadata i32 9, metadata !34, metadata !DIExpression()), !dbg !35
----------------
djtodoro wrote:
> TBAA metadata are usually unnecessary as well, so I think you can delete it.
Thanks for your tricks. I will incorporate this in next version.


================
Comment at: llvm/test/DebugInfo/dwarfdump-implicit_pointer_instcomb.ll:44
+; Function Attrs: nounwind readnone speculatable willreturn
+declare void @llvm.dbg.value(metadata, metadata, metadata) #2
+
----------------
djtodoro wrote:
> Since you dropped the attributes, we can delete those '#2' (#N) from the testcase. 
I shall incorporate this in next version.


================
Comment at: llvm/test/DebugInfo/dwarfdump-implicit_pointer_instcomb.ll:52
+!1 = distinct !DIGlobalVariable(name: "gvar", scope: !2, file: !3, line: 14, type: !6, isLocal: false, isDefinition: true)
+!2 = distinct !DICompileUnit(language: DW_LANG_C99, file: !3, producer: "clang version 10.0.0 (https://github.com/llvm/llvm-project.git 11c4347ce784b0d0faaae757ccbb525034b36946)", isOptimized: true, runtimeVersion: 0, emissionKind: FullDebug, enums: !4, globals: !5, nameTableKind: None)
+!3 = !DIFile(filename: "dwarfdump-implicit_pointer_instcomb.c", directory: "/home/alok/work/implicit_pointer", checksumkind: CSK_MD5, checksum: "1c991e568deb5a6321b60bc8bf8be8d6")
----------------
djtodoro wrote:
> `producer: "clang version 10.0.0"` is enough.
I shall incorporate this in next version.


================
Comment at: llvm/test/DebugInfo/dwarfdump-implicit_pointer_instcomb.ll:53
+!2 = distinct !DICompileUnit(language: DW_LANG_C99, file: !3, producer: "clang version 10.0.0 (https://github.com/llvm/llvm-project.git 11c4347ce784b0d0faaae757ccbb525034b36946)", isOptimized: true, runtimeVersion: 0, emissionKind: FullDebug, enums: !4, globals: !5, nameTableKind: None)
+!3 = !DIFile(filename: "dwarfdump-implicit_pointer_instcomb.c", directory: "/home/alok/work/implicit_pointer", checksumkind: CSK_MD5, checksum: "1c991e568deb5a6321b60bc8bf8be8d6")
+!4 = !{}
----------------
djtodoro wrote:
> We usually make tests as short as possible, so my advice is to avoid your exact path from local PC here, you can just put "/dir".
I shall incorporate this in next version.


================
Comment at: llvm/test/DebugInfo/dwarfdump-implicit_pointer_instcomb.ll:61
+!10 = !{i32 1, !"wchar_size", i32 4}
+!11 = !{!"clang version 10.0.0 (https://github.com/llvm/llvm-project.git 11c4347ce784b0d0faaae757ccbb525034b36946)"}
+!12 = distinct !DISubprogram(name: "func", scope: !3, file: !3, line: 16, type: !13, scopeLine: 16, flags: DIFlagPrototyped | DIFlagAllCallsDescribed, spFlags: DISPFlagDefinition | DISPFlagOptimized, unit: !2, retainedNodes: !16)
----------------
djtodoro wrote:
> `producer: "clang version 10.0.0"` is enough.
I shall incorporate this in next version.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69886/new/

https://reviews.llvm.org/D69886