[PATCH] D69886: [DebugInfo] Support for DW_OP_implicit_pointer (CodeGen phase)

[Alok Kumar Sharma via Phabricator via llvm-commits]

alok marked 2 inline comments as done and 2 inline comments as done.
alok added inline comments.


================
Comment at: llvm/test/DebugInfo/dwarfdump-implicit_pointer_instcomb.ll:1
+; RUN: clang %s -O2 -gdwarf-5 -o %t.o
+; RUN: llvm-dwarfdump  %t.o | FileCheck %s
----------------
vsk wrote:
> alok wrote:
> > jmorse wrote:
> > > I don't believe running clang in an internal LLVM test is supported, this should probably be running llc -O2 -filetype=obj instead? Same with the other tests.
> > Thanks for pointing it out. I shall incorporate this comment.
> Please include the original C source when applicable, so that future authors have steps to regenerate the test if needed.
Incorporated this comment.


================
Comment at: llvm/test/DebugInfo/dwarfdump-implicit_pointer_mem2reg.ll:7
+; 1. Test if More than one member location list is printed 
+;    (for pointer to scalar)
+; CHECK:       DW_AT_location        (
----------------
alok wrote:
> vsk wrote:
> > Please only capitalize words where necessary.
> Sure. I shall incorporate this in next version.
Incorporated this comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69886/new/

https://reviews.llvm.org/D69886