[PATCH] D69911: [llvm-ar] Support verbose mode for operation 'x'

[James Henderson via Phabricator via llvm-commits]

jhenderson requested changes to this revision.
jhenderson added a comment.
This revision now requires changes to proceed.

Code change looks good, but I've got a concern about the testing. (requesting changes to cancel approval)



================
Comment at: llvm/test/tools/llvm-ar/extract.test:8
 RUN: llvm-ar cr %t/empty.a
-RUN: llvm-ar x %t/empty.a 2>&1 | count 0
+RUN: llvm-ar xv %t/empty.a 2>&1 | count 0
 
----------------
You need test cases for extracting without 'v', to show the behaviour in that case. With this change, 'x' alone is untested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69911/new/

https://reviews.llvm.org/D69911