[PATCH] D69849: [mips] Implement Octeon+ `saa` and `saad` instructions

[Simon Atanasyan via Phabricator via llvm-commits]

atanasyan added a comment.

Thanks for review.

In D69849#1735518 <https://reviews.llvm.org/D69849#1735518>, @Petar.Avramovic wrote:

> Correction from previous comment, tests for SaaAddr and SaadAddr are already present.


Anyway I decided to add more tests. In particular, check saa <reg>, <symbol> expansion in case of PIC.

> Remaining question is about flags for tests, 
>  for gnu-as both `-mips32` and `-mips64` are not compatible with  `-march=octeon+`, minimum requirement is `-mips64r2`, but feature compatibility could be addressed in another patch.

You are right. Now it's possible to pass `-mips64 -march=octeon` to the `clang` and do not get any errors. I'm going to solve that as a separate patch for the driver.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69849/new/

https://reviews.llvm.org/D69849