[PATCH] D69932: [IR] Redefine Freeze instruction

Juneyoung Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 6 23:37:40 PST 2019


aqjune created this revision.
Herald added a reviewer: whitequark.
Herald added subscribers: llvm-commits, jfb, dexonsmith, steven_wu, hiraditya, mehdi_amini.
Herald added a reviewer: deadalnix.
Herald added a project: LLVM.
aqjune added reviewers: craig.topper, jdoerfert, lebedev.ri.
aqjune added subscribers: nlopes, regehr.

This patch redefines freeze instruction from being UnaryOperator to a subclass of UnaryInstruction.

ConstantExpr freeze is removed, as discussed in the previous review.
FreezeOperator is not added because there's no ConstantExpr freeze.
`freeze i8* null` test is added to `test/Bindings/llvm-c/freeze.ll` as well, because the null pointer-related bug in `tools/llvm-c/echo.cpp` is now fixed.
InstVisitor has visitFreeze now because freeze is not unaryop anymore.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D69932

Files:
  llvm/include/llvm-c/Core.h
  llvm/include/llvm/Bitcode/LLVMBitCodes.h
  llvm/include/llvm/IR/IRBuilder.h
  llvm/include/llvm/IR/InstVisitor.h
  llvm/include/llvm/IR/Instruction.def
  llvm/include/llvm/IR/Instructions.h
  llvm/include/llvm/IR/Operator.h
  llvm/include/llvm/IR/PatternMatch.h
  llvm/lib/AsmParser/LLLexer.cpp
  llvm/lib/AsmParser/LLParser.cpp
  llvm/lib/AsmParser/LLParser.h
  llvm/lib/AsmParser/LLToken.h
  llvm/lib/Bitcode/Reader/BitcodeReader.cpp
  llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h
  llvm/lib/IR/ConstantFold.cpp
  llvm/lib/IR/Core.cpp
  llvm/lib/IR/Instruction.cpp
  llvm/lib/IR/Instructions.cpp
  llvm/lib/IR/Verifier.cpp
  llvm/test/Bindings/OCaml/core.ml
  llvm/test/Bindings/llvm-c/freeze.ll
  llvm/test/Bitcode/compatibility.ll
  llvm/test/Transforms/MergeFunc/inline-asm.ll
  llvm/unittests/IR/VerifierTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69932.228182.patch
Type: text/x-patch
Size: 38331 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191107/a472294a/attachment-0001.bin>


More information about the llvm-commits mailing list