[PATCH] D69552: Move floating point related entities to namespace level

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 6 21:55:02 PST 2019


arsenm added inline comments.


================
Comment at: llvm/unittests/IR/IRBuilderTest.cpp:290
+  ASSERT_EQ(CII->getExceptionBehavior(), fp::ebMayTrap);
+  ASSERT_EQ(CII->getRoundingMode(), fp::rmDownward);
 
----------------
EXPECT_EQ, not assert. The argument order should also be swapped 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69552/new/

https://reviews.llvm.org/D69552





More information about the llvm-commits mailing list