[PATCH] D69817: Fix OrcError build with modules enabled.

Wed Nov 6 16:29:34 PST 2019

lhames added a comment.

I couldn’t reproduce this -DLLVM_ENABLE_MODULES=On and my system compiler. I’ll try a 2-stage build and see if I have any luck with that.

Volodymyr — Can you provide more context around this error:

> host-compiler/bin/../include/c++/v1/memory:3003:32: error: definition of 'JITSymbolNotFound' must be imported from module 'LLVM_ExecutionEngine.Orc.CompileOnDemandLayer' before it is required

I’m not quite sure how to parse it, but if it’s saying that CompileOnDemandLayer needs to import OrcError in modules builds then we should just do that (it’s a correct and expected requirement).

If it’s implying that JITSymbolNotFound is being provided *by* CompileOnDemandLayer then that’s a modules bug of some kind.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69817/new/

https://reviews.llvm.org/D69817