[PATCH] D69918: [CR][WIP] Add `subWithNoWrap()` method

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 6 14:10:52 PST 2019


lebedev.ri updated this revision to Diff 228140.
lebedev.ri marked 2 inline comments as done.
lebedev.ri added a comment.

In D69918#1736201 <https://reviews.llvm.org/D69918#1736201>, @nikic wrote:

> LGTM. addWithNoWrap() has some more tests for specific inputs, but I don't think we really need them here.


Well, okay then.
Thank you for the review!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69918/new/

https://reviews.llvm.org/D69918

Files:
  llvm/include/llvm/IR/ConstantRange.h
  llvm/lib/IR/ConstantRange.cpp
  llvm/unittests/IR/ConstantRangeTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69918.228140.patch
Type: text/x-patch
Size: 8405 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191106/cc6caa94/attachment.bin>


More information about the llvm-commits mailing list