[PATCH] D69918: [CR][WIP] Add `subWithNoWrap()` method

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM. addWithNoWrap() has some more tests for specific inputs, but I don't think we really need them here.



================
Comment at: llvm/lib/IR/ConstantRange.cpp:869
+  // we must return Empty set. In this case, we get that for free, because we
+  // get lucky that interception with [MAX, MAX] results in empty set.
 
----------------
interception -> intersection

I'd may write "that intersection of add() with uadd_sat()/sadd_sat() results in an empty set", as it's not necessary the MAX bound.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69918/new/

https://reviews.llvm.org/D69918