[PATCH] D69013: [AArch64][X86] Don't assume __powidf2 is available on Windows.
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 6 13:15:53 PST 2019
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
In D69013#1734847 <https://reviews.llvm.org/D69013#1734847>, @efriedma wrote:
> Updated. I'm a little uncomfortable with the untested codepath, but I guess it isn't any worse than report_fatal_error, which always kills the process.
These days I'm trying to take a hard look at report_fatal_error and ask why it's not either unreachable, assert, or error.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69013/new/
https://reviews.llvm.org/D69013
More information about the llvm-commits
mailing list