[PATCH] D69562: Mapping of FP operations to constrained intrinsics

[Kevin P. Neal via Phabricator via llvm-commits]

kpn added inline comments.


================
Comment at: llvm/lib/IR/FloatingPoint.cpp:172
+      default:
+        break;
+      }
----------------
arsenm wrote:
> arsenm wrote:
> > I think this should assert or something on unhandled target intrinsics. Right now it will just return then original ID which is probably not expected
> Nevermind, I can't read. It will return not_intrinsic although I still think this is a possible source of error
Honestly, I agree that this being a possible source of error. But I'm not sure we have an easy check that callers can make to find out if they should be calling this function in the first place. Without an easy check we're left with calling this function and checking the return value.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69562/new/

https://reviews.llvm.org/D69562