[PATCH] D69870: [builtins] Implement rounding mode support for i386/x86_64

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added inline comments.


================
Comment at: compiler-rt/lib/builtins/i386/fp_mode.c:43-45
+  cw &= X87_RMODE_MASK;
+
+  switch (cw) {
----------------
craig.topper wrote:
> nickdesaulniers wrote:
> > `switch (cw & X87_RMODE_MASK)`. LLVM will optimize such expressions in a switch.
> By the time its gets to IR and goes through mem2reg/SROA it should look the same right?
Yep. Just slightly more concise.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69870/new/

https://reviews.llvm.org/D69870