[PATCH] D69895: [yaml2obj/obj2yaml] - Add support for SHT_LLVM_LINKER_OPTIONS sections.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/include/llvm/ObjectYAML/ELFYAML.h:332
+struct LinkerOption {
+  LinkerOption(StringRef K, StringRef V) : Key(K), Value(V) {}
+  LinkerOption() = default;
----------------
Just delete user-defined constructors.


================
Comment at: llvm/test/tools/obj2yaml/linker-options.yaml:29
+  - Name: .linker-options-valid1
+    Type: SHT_LLVM_LINKER_OPTIONS
+    Content: "61006200"
----------------
Align the values (The `Content:` value has the largest indentation).


================
Comment at: llvm/test/tools/obj2yaml/linker-options.yaml:31
+    Content: "61006200"
+  - Name: .linker-options-valid2
+    Type: SHT_LLVM_LINKER_OPTIONS
----------------
Align the values.


================
Comment at: llvm/test/tools/obj2yaml/linker-options.yaml:58
+## 1) Empty content.
+  - Name: .linker-options-empty
+    Type: SHT_LLVM_LINKER_OPTIONS
----------------
Align the values.


================
Comment at: llvm/test/tools/obj2yaml/linker-options.yaml:61
+    Content: ""
+## 2) Non-null terminated content.
+  - Name: .linker-options-no-null
----------------
jhenderson wrote:
> Perhaps also a case combining 2) and 3), i.e. Content: "610062" or something like that.
Non-NUL terminated


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69895/new/

https://reviews.llvm.org/D69895