[PATCH] D69552: Move floating point related entities to namespace level

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 6 08:54:28 PST 2019


arsenm added inline comments.


================
Comment at: llvm/unittests/IR/IRBuilderTest.cpp:252-253
   CII = cast<ConstrainedFPIntrinsic>(V);
-  ASSERT_TRUE(CII->getExceptionBehavior() == ConstrainedFPIntrinsic::ebIgnore);
-  ASSERT_TRUE(CII->getRoundingMode() == ConstrainedFPIntrinsic::rmUpward);
+  ASSERT_TRUE(CII->getExceptionBehavior() == fp::ebIgnore);
+  ASSERT_TRUE(CII->getRoundingMode() == fp::rmUpward);
 
----------------
These should all use EXPECT_EQ


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69552/new/

https://reviews.llvm.org/D69552





More information about the llvm-commits mailing list