[PATCH] D69889: [DebugInfo] Avoid creating entry values for clobbered registers

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

@dstenb Thanks!



================
Comment at: llvm/lib/CodeGen/LiveDebugValues.cpp:1326
+    // block, in which case we shouldn't create an entry value.
+    for (const MachineOperand &MO : MI.operands())
+      if (MO.isReg() && MO.isDef() && MO.getReg())
----------------
Can we put this in a helper?


================
Comment at: llvm/lib/CodeGen/LiveDebugValues.cpp:1331
+
     if (MI.isDebugValue() && IsUnmodifiedFuncParam(MI) &&
         !MI.isIndirectDebugValue() && IsRegOtherThanSPAndFP(MI.getOperand(0)) &&
----------------
Maybe all of this can go in a helper as well. I think that should simplify the code here.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69889/new/

https://reviews.llvm.org/D69889