[PATCH] D69887: [FEnv] File with properties of constrained intrinsics

Wed Nov 6 05:29:56 PST 2019

uweigand added a comment.

I really like that approach.  Unfortunately, this part of it does sort of partially revert one of the changes I recently made:

  if (Opcode == ISD::STRICT_FP_ROUND)
    Opers.push_back(
        DAG.getTargetConstant(0, sdl, TLI.getPointerTy(DAG.getDataLayout())));

The comparison patch (https://reviews.llvm.org/D69281) will introduce a lot more cases where we need an extra argument on the DAG side.

So maybe the best solution would be to extend the .def file with an additional column listing "extra arguments" for the DAG node -- then the DAG node could be constructed fully automatically without any per-opcode special cases in this routine.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69887/new/

https://reviews.llvm.org/D69887