[PATCH] D69416: [Examples] Add IRTransformations directory to examples.

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 228039.
fhahn marked 9 inline comments as done.
fhahn added a comment.

Thanks. Updated to address the comments.

In D69416#1733007 <https://reviews.llvm.org/D69416#1733007>, @andwar wrote:

> This is great stuff, thank you for doing this!
>
> 1. Why not test with all versions (`v1`, `v2` and `v3`) in all tests? Does the output change?


Nope, I just did not update all tests. it's done now :)

> 2. AFAIK there are no official guidelines on this (and both approaches are used in practice), but I'd rename `SimplifyCFGLegacyPass` to `SimplifyCFGLegacy` (fewer characters, meaning still clear). But please use the one you prefer the most.

I'd prefer to keep it as is for now.

> 3. I'd prefer to see this fully working with the new PM or no new PM support at all. Otherwise it can be confusing.

Agreed, I've removed the partial new PM stuff for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69416/new/

https://reviews.llvm.org/D69416

Files:
  llvm/CMakeLists.txt
  llvm/examples/CMakeLists.txt
  llvm/examples/IRTransforms/CMakeLists.txt
  llvm/examples/IRTransforms/InitializePasses.cpp
  llvm/examples/IRTransforms/InitializePasses.h
  llvm/examples/IRTransforms/SimplifyCFG.cpp
  llvm/examples/IRTransforms/SimplifyCFG.h
  llvm/test/Examples/IRTransforms/SimplifyCFG/tut-simplify-cfg-blockaddress.ll
  llvm/test/Examples/IRTransforms/SimplifyCFG/tut-simplify-cfg1.ll
  llvm/test/Examples/IRTransforms/SimplifyCFG/tut-simplify-cfg2-dead-block-order.ll
  llvm/test/Examples/IRTransforms/SimplifyCFG/tut-simplify-cfg3-phis.ll
  llvm/test/Examples/IRTransforms/SimplifyCFG/tut-simplify-cfg4-multiple-duplicate-cfg-updates.ll
  llvm/test/Examples/IRTransforms/SimplifyCFG/tut-simplify-cfg5-del-phis-for-dead-block.ll
  llvm/test/Examples/IRTransforms/SimplifyCFG/tut-simplify-cfg6-dead-self-loop.ll
  llvm/tools/opt/CMakeLists.txt
  llvm/tools/opt/opt.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69416.228039.patch
Type: text/x-patch
Size: 36913 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191106/e6217ce6/attachment.bin>