[PATCH] D69556: [CodeGen] Move ARMCodegenPrepare to TypePromotion

[Sam Parker via Phabricator via llvm-commits]

samparker marked an inline comment as done.
samparker added inline comments.


================
Comment at: llvm/lib/CodeGen/TypePromotion.cpp:208
 
   if (auto *Ld = dyn_cast<LoadInst>(V))
     Ty = cast<PointerType>(Ld->getPointerOperandType())->getElementType();
----------------
craig.topper wrote:
> Are these two lines needed? The pointer element type should match the result type of the load right? Only asking because this code will need to be updated if we ever move to opaque pointers.
Yeah, this looks odd.... I'll remove it, thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69556/new/

https://reviews.llvm.org/D69556