[PATCH] D69557: AsmParser: Allow FMF on varargs call

Wed Nov 6 03:26:30 PST 2019

foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

In D69557#1725616 <https://reviews.llvm.org/D69557#1725616>, @tpr wrote:

> In D69557#1725564 <https://reviews.llvm.org/D69557#1725564>, @foad wrote:
>
> > In D69557#1725496 <https://reviews.llvm.org/D69557#1725496>, @spatel wrote:
> >
> > > Does D69161 <https://reviews.llvm.org/D69161> cover this change? If so, we could add the test there and fix the problem in 1 step.
> >
> >
> > I think this bug fix is orthogonal to D69161 <https://reviews.llvm.org/D69161>, which adds new functionality.
>
>
> The way you have changed the call check to !isa<FPMathOperator>(CI) means you might have accidentally fixed my bug anyway. I'll check later.

You're right, I have accidentally fixed your bug. It would still be good to commit your test case, which LGTM.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69557/new/

https://reviews.llvm.org/D69557