[PATCH] D69839: [DebugInfo] Fix for stopping emission of debug_macinfo section in normal case and -fno-debug-macro switch enabled case.
Sourabh Singh Tomar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 5 11:15:36 PST 2019
SouraVX marked an inline comment as done.
SouraVX added inline comments.
================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:2782
DIMacroNodeArray Macros = CUNode->getMacros();
if (!Macros.empty()) {
Asm->OutStreamer->EmitLabel(U.getMacroLabelBegin());
----------------
I also considered, inserting a return statement here, that also solves our problem,But code becomes a less let say "readable". because we have emit{handleMacrosNodes} in else case.
Doing this while entering / preparing for emission seems fine to me ??
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69839/new/
https://reviews.llvm.org/D69839
More information about the llvm-commits
mailing list