[PATCH] D69809: Wrong debug info generated at -O2 (-O0 is correct)

[kamlesh kumar via Phabricator via llvm-commits]

kamleshbhalui marked an inline comment as done.
kamleshbhalui added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:3225
+
       eraseInstFromFunction(*I);
       ++NumDeadInst;
----------------
lebedev.ri wrote:
> lebedev.ri wrote:
> > What about other users of `eraseInstFromFunction()`?
> > Should this go into that function?
> My comment wasn't addressed.
I have seen this is in EarlyCSE.
And yes, It should go into several other places too, But need to come up with testcases.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69809/new/

https://reviews.llvm.org/D69809