[PATCH] D69809: Wrong debug info generated at -O2 (-O0 is correct)

[kamlesh kumar via Phabricator via llvm-commits]

kamleshbhalui added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/debuginfo-dce.ll:36-37
 ; CHECK: define void @salvage_load
 ; CHECK-NEXT: entry:
-; CHECK-NOT: dbg.value
+; CHECK-NEXT: dbg.value
   store %struct.entry* %1, %struct.entry** %im_not_dead, align 8
----------------
davide wrote:
> Do you know why this changed?
Before the fix instcombiner was deleting all the users (even dbg.value ) of a trivially dead instruction.
But now we mark dbg.value as undef instead of deleting it .
and that's why modified the check like this.




Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69809/new/

https://reviews.llvm.org/D69809