[PATCH] D69817: Fix OrcError build with modules enabled.

[Volodymyr Sapsai via Phabricator via llvm-commits]

vsapsai added a comment.

In D69817#1734651 <https://reviews.llvm.org/D69817#1734651>, @beanz wrote:

> `RPCUtils.h` and `RPCSerialization.h` can both also be excluded.


I don't think that's the right fix as it moves a module map from representing a project structure towards having a random set of headers. But even after excluding 3 headers  there are errors

> llvm-project/llvm/include/llvm/Support/Error.h:331:10: error: no matching conversion for functional-style cast from 'typename __unique_if<JITSymbolNotFound>::__unique_single' (aka 'unique_ptr<llvm::orc::JITSymbolNotFound>') to 'llvm::Error'

  return Error(std::make_unique<ErrT>(std::forward<ArgTs>(Args)...));
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~



> host-compiler/bin/../include/c++/v1/memory:3003:32: error: definition of 'JITSymbolNotFound' must be imported from module 'LLVM_ExecutionEngine.Orc.CompileOnDemandLayer' before it is required

  return unique_ptr<_Tp>(new _Tp(_VSTD::forward<_Args>(__args)...));
                             ^

Have you seen these errors before? The second error implies a module map with excluded headers doesn't work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69817/new/

https://reviews.llvm.org/D69817