[PATCH] D69003: [dsymutil] Explicitly link against libatomic when necessary
Gokturk Yuksek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 5 14:20:09 PST 2019
gokturk updated this revision to Diff 227964.
gokturk retitled this revision from "[dsymutil] Add ${system_libs} to target link libraries" to "[dsymutil] Explicitly link against libatomic when necessary".
gokturk edited the summary of this revision.
gokturk added a comment.
Herald added subscribers: s.egerton, PkmX, simoncook.
Here's the proposed patch. I think this is the least invasive of all. Just check if passing '-latomic' is required inside dsymutil's cmake file.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69003/new/
https://reviews.llvm.org/D69003
Files:
llvm/tools/dsymutil/CMakeLists.txt
Index: llvm/tools/dsymutil/CMakeLists.txt
===================================================================
--- llvm/tools/dsymutil/CMakeLists.txt
+++ llvm/tools/dsymutil/CMakeLists.txt
@@ -39,3 +39,7 @@
if(APPLE)
target_link_libraries(dsymutil PRIVATE "-framework CoreFoundation")
endif(APPLE)
+
+if(HAVE_CXX_ATOMICS_WITH_LIB OR HAVE_CXX_ATOMICS64_WITH_LIB)
+ target_link_libraries(dsymutil PRIVATE atomic)
+endif()
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69003.227964.patch
Type: text/x-patch
Size: 425 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191105/7f3682a1/attachment.bin>
More information about the llvm-commits
mailing list