[PATCH] D69685: Prevent adding lld to test dependency (TEST_DEPS) when lld project is not built

Kelvin Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 5 13:43:22 PST 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rG1e1ae46595b1: [CMake] Prevent adding lld to test dependency (TEST_DEPS) when lld project is… (authored by kkwli0).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69685/new/

https://reviews.llvm.org/D69685

Files:
  compiler-rt/cmake/Modules/AddCompilerRT.cmake


Index: compiler-rt/cmake/Modules/AddCompilerRT.cmake
===================================================================
--- compiler-rt/cmake/Modules/AddCompilerRT.cmake
+++ compiler-rt/cmake/Modules/AddCompilerRT.cmake
@@ -465,7 +465,7 @@
     set(TEST_LINK_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${TEST_LINK_FLAGS}")
     separate_arguments(TEST_LINK_FLAGS)
   endif()
-  if(NOT COMPILER_RT_STANDALONE_BUILD AND COMPILER_RT_HAS_LLD)
+  if(NOT COMPILER_RT_STANDALONE_BUILD AND COMPILER_RT_HAS_LLD AND TARGET lld)
     # CMAKE_EXE_LINKER_FLAGS may contain -fuse=lld
     # FIXME: -DLLVM_ENABLE_LLD=ON and -DLLVM_ENABLE_PROJECTS without lld case.
     list(APPEND TEST_DEPS lld)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69685.227961.patch
Type: text/x-patch
Size: 673 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191105/67638d78/attachment.bin>


More information about the llvm-commits mailing list