[PATCH] D69734: [globalisel] Rename G_GEP to G_PTR_ADD
Daniel Sanders via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 5 12:20:04 PST 2019
dsanders added a comment.
In D69734#1734315 <https://reviews.llvm.org/D69734#1734315>, @arsenm wrote:
> In D69734#1734287 <https://reviews.llvm.org/D69734#1734287>, @dsanders wrote:
>
> > Thanks.
> >
> > I realized I missed a couple things in this patch this morning:
> >
> > - Filenames containing 'gep'
> > - Functions named buildGep() and similar I'll fix both of this this before pushing
>
>
> If you're fixing names of instructions, that buildUndef doesn't match the G_IMPLICIT_DEF name has bothered me. I'm not sure which should be renamed
Probably buildUndef() should change to buildImplicitDef(). I'm going to leave it for the moment though just to let this change flow down to our downstream repos before I do another big rename
> especially since freeze seems to be happening
I'm not sure what you're referring to here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69734/new/
https://reviews.llvm.org/D69734
More information about the llvm-commits
mailing list