[PATCH] D69552: Move floating point related entities to namespace level

[Andy Kaylor via Phabricator via llvm-commits]

andrew.w.kaylor added a comment.

I like this. I have just one minor suggestion.



================
Comment at: llvm/include/llvm/IR/FloatingPoint.h:29
+/// for details.
+enum RoundingMode : uint8_t {
+  rmDynamic,   ///< This corresponds to "fpround.dynamic".
----------------
What would you think of adding a wrapping namespace to give these more context? So instead of "llvm::RoundingMode" we'd have "llvm::fp::RoundingMode" or, more commonly "fp::RoundingMode".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69552/new/

https://reviews.llvm.org/D69552