[PATCH] D69824: Extends the tblgen macro to allow mlir-tblgen to be installed

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: llvm/cmake/modules/TableGen.cmake:163
 
-  if (${project} STREQUAL LLVM AND NOT LLVM_INSTALL_TOOLCHAIN_ONLY AND LLVM_BUILD_UTILS)
+  if (${project} STREQUAL LLVM OR ${project} STREQUAL MLIR AND NOT LLVM_INSTALL_TOOLCHAIN_ONLY AND LLVM_BUILD_UTILS)
     set(export_to_llvmexports)
----------------
Is this correct? Usually OR has lower precedence then AND.

Also that seems a bit intrusive to me.  What about replacing the existing `if (${project} STREQUAL LLVM` part with an extra argument to the macro that indicates from the call site to install or not?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69824/new/

https://reviews.llvm.org/D69824