[PATCH] D69085: [libFuzzer] don't change sanitizer_report_fd for fuchsia.

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 5 11:06:31 PST 2019


phosek added inline comments.


================
Comment at: compiler-rt/lib/fuzzer/FuzzerIO.cpp:119
+#if !LIBFUZZER_FUCHSIA
+// Fuchsia does not support redirecting clang's reports to a file descriptor.
+// These reports are also logged to the console and show up via fx syslog so
----------------
Can you indent the comment so it starts on the same column as the rest of this block?


================
Comment at: compiler-rt/lib/fuzzer/FuzzerIO.cpp:120
+// Fuchsia does not support redirecting clang's reports to a file descriptor.
+// These reports are also logged to the console and show up via fx syslog so
+// it's not important if they are not in the fuzzer output.
----------------
I'd omit the second sentence, fx syslog is an internal detail of Fuchsia development workflow and is irrelevant here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69085/new/

https://reviews.llvm.org/D69085





More information about the llvm-commits mailing list