[PATCH] D69734: [globalisel] Rename G_GEP to G_PTR_ADD

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 5 10:29:12 PST 2019


arsenm added a comment.

In D69734#1734287 <https://reviews.llvm.org/D69734#1734287>, @dsanders wrote:

> Thanks.
>
> I realized I missed a couple things in this patch this morning:
>
> - Filenames containing 'gep'
> - Functions named buildGep() and similar I'll fix both of this this before pushing


If you're fixing names of instructions, that buildUndef doesn't match the G_IMPLICIT_DEF name has bothered me. I'm not sure which should be renamed, especially since freeze seems to be happening


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69734/new/

https://reviews.llvm.org/D69734





More information about the llvm-commits mailing list