[PATCH] D66871: [SVE] MVT scalable size queries

[Graham Hunter via Phabricator via llvm-commits]

huntergr added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/ValueTypes.h:319
 
-    /// Return the number of bits overwritten by a store of the specified value
+    /// Returns the number of bits overwritten by a store of the specified value
     /// type.
----------------
rovka wrote:
> That's a weird change...
I think that was a copy-paste from elsewhere. Will revert.


================
Comment at: llvm/utils/TableGen/CodeGenDAGPatterns.cpp:520
     // to a non-vector, it should return false (to avoid removal).
     if (A.isVector() != B.isVector())
       return false;
----------------
rovka wrote:
> Why does LE care about isVector and LT doesn't?
> 
> In any case, I think both functions would benefit from being rewritten using std::tie and the corresponding operators.
LT seems to be used with filtered min/max functions below and will only operate on either only vector or only scalar MVTs, so never compares between them.

LE is then explicitly used to remove MVTs from Typesets that may have mixed scalar and vector MVTs, so needs to avoid comparing them.

I'll try reworking them with std::tie.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66871/new/

https://reviews.llvm.org/D66871