[PATCH] D69672: DWARFDebugLoclists: Move to a incremental parsing model
Jonas Devlieghere via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 5 09:42:46 PST 2019
JDevlieghere accepted this revision.
JDevlieghere added a comment.
Personally I'm not a big fan of callbacks, but it seems like this was well thought through. My original suggestion of doing a two-step parse also wouldn't allow you to abort parsing, which is possible here by returning false form the callback.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69672/new/
https://reviews.llvm.org/D69672
More information about the llvm-commits
mailing list