[PATCH] D69561: [ThinLTO] Import readonly vars with refs

[Eugene Leviant via Phabricator via llvm-commits]

evgeny777 marked an inline comment as done.
evgeny777 added inline comments.


================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:5853
+          (Flags & 0x20) ||
+          (Version >= 5 && TheIndex.withGlobalValueDeadStripping()));
       break;
----------------
tejohnson wrote:
> I don't follow the second check, since the WithGlobalValueDeadStripping flag was added to the index before attribute propagation was supported.
We have constant propagation in index since version 5 and if value of true of WithGlobalValueDeadStripping flag means constant propagation has run. I tend to remove this check for the sake of simplicity though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69561/new/

https://reviews.llvm.org/D69561