[PATCH] D69833: [ObjC][ARC] Ignore lifetime markers between *ReturnValue calls

[John McCall via Phabricator via llvm-commits]

rjmccall added a comment.

Generally LGTM, but one minor thing.



================
Comment at: llvm/lib/Transforms/ObjCARC/ObjCARCOpts.cpp:664
       --I;
-    while (I != Begin && IsNoopInstruction(&*I));
+    while (I != Begin && (IsNoopInstruction(&*I) || isSafeBetweenRVCalls(&*I)));
     if (GetBasicARCInstKind(&*I) == ARCInstKind::AutoreleaseRV &&
----------------
`isSafeBetweenRVCalls` also checks `IsNoopInstruction`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69833/new/

https://reviews.llvm.org/D69833