[PATCH] D69639: Add support for lowering 32-bit/64-bit pointers

[Amy Huang via Phabricator via llvm-commits]

akhuang marked 3 inline comments as done.
akhuang added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:2396-2397
+  const TargetMachine &TM = getTargetMachine();
+  if ((isPtrSizeOrDefaultAddrSpace(SrcAS) &&
+       isPtrSizeOrDefaultAddrSpace(DestAS)) &&
+      TM.getPointerSize(SrcAS) != TM.getPointerSize(DestAS))
----------------
arsenm wrote:
> These look redundant with the size check to me
Good point - I guess removing the address space check would allow casting from arbitrary address spaces to ptr32/ptr64, which makes sense. 






Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69639/new/

https://reviews.llvm.org/D69639