[PATCH] D69672: DWARFDebugLoclists: Move to a incremental parsing model

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX marked an inline comment as done.
SouraVX added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDie.cpp:121
 
     bool UseLocLists = !U->isDWOUnit();
     auto Data = [&] {
----------------
labath wrote:
> SouraVX wrote:
> > @labath , Not sure about this piece of code, is this patch has some relationship with D68271 ?? 
> > I noticed this piece of code their, and which is uncommitted ??
> Yes, it is based on that patch, mainly because I was too lazy to create a new branch for this work. What is it that you are unsure of? (Is it just it's presence, or something more?)
Just the presence here(when I was rebaseing), I wasn't sure it's stemming / related from that patch.
I believe you must've forgotten to specified it's dependence / related to D68271. ??
Thanks for clarifying this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69672/new/

https://reviews.llvm.org/D69672