[PATCH] D69462: [DebugInfo]: Support for debug_loclists.dwo section in llvm and llvm-dwarfdump.

Mon Nov 4 10:01:46 PST 2019

labath added a comment.

Sorry for the trouble, I should be able to land the other patches soon.

================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDie.cpp:128-130
+    if (Loclistsv5)
+      LoclistsSectionData = UseDWO ? Obj.getLoclistsDWOSection().Data
+                                   : Obj.getLoclistsSection().Data;
----------------
dblaikie wrote:
> SouraVX wrote:
> > dblaikie wrote:
> > > I'm /guessing/ this is probably not compatible with DWP files (the DWARFUnit's "LocSectionData" is carefully populated from the DWP's cu_index - see DWARFUnit's ctor & try testing dumping of a DWP file (admittedly, there's no DWP tool that can produce a DWP file for DWARFv5 right now, so you'd have to hand-craft one/locally patch llvm-dwp).
> > I haven't got a chance to look into details of llvm-dwp utility. 
> > My Initial plan is to get loclist work in split mode, so that at least using LLDB{GDB is mostly broken for dwarf-5 compiled binaries} we can debug a binary compiled with -gdwarf-5 -gsplit-dwarf.
> >  As of now LLDB is not able to handle loclists.dwo section. May be @labath can add more to this.
> Yeah, maybe leave a FIXIT here about DWP support? 
> 
> I think the whole thing needs a bit more deep surgery for more complete/general DWP support & such, out of scope for this change.
Yep, lldb does not support `loclists.dwo` (and its support for the non-dwo variant is somewhat dodgy as well). I am planning to address all of that by making lldb use the llvm classes for parsing (hence my other patches).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69462/new/

https://reviews.llvm.org/D69462