[PATCH] D68271: DWARFDebugLoclists: Make it possible to read relocated addresses

[Pavel Labath via Phabricator via llvm-commits]

labath marked 2 inline comments as done.
labath added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDie.cpp:124-127
+        return DWARFDataExtractor(Obj, Obj.getLoclistsSection(),
+                                  Ctx.isLittleEndian(), Obj.getAddressSize());
+      return DWARFDataExtractor(U->getLocSectionData(), Ctx.isLittleEndian(),
+                                Obj.getAddressSize());
----------------
dblaikie wrote:
> Is this written with a lambda because DWARFDataExtractor isn't assignable? Perhaps it should/could be made assignable?
It's not default-constructible (which I normally consider to be a good thing) so I had to initialize it in a single statement. That said, I have no idea why I ended up with a lambda here -- a plain ternary operator would work just fine. Using ?: now.


================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/debug_loclists.s:11-12
+# CHECK-NEXT:        Addr idx 57005 (w/ length 1): DW_OP_reg4 RSI)
+
+
+        .text
----------------
dblaikie wrote:
> Could you include the source & commands used to build this assembly for reference?
There isn't a "source", really. I was just adding a bunch of interesting location list entries by hand. (TBE, I did use some source to produce the minimal debug_info blurb needed to be able to print out, but I don't know what it was, and it has been mangled/reduced beyond recognition anyway.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68271/new/

https://reviews.llvm.org/D68271