[PATCH] D69392: [ARM] MVE interleaving load and stores.

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 4 06:51:13 PST 2019


samparker added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp:817
+    if (ST->hasMVEIntegerOps() && Factor == 2 && NumElts / Factor > 2 &&
+        VecTy->isIntOrIntVectorTy() && DL.getTypeSizeInBits(SubVecTy) <= 128)
+      return 2 * BaseCost;
----------------
if this is handling the smaller vector types, shouldn't this be <= 64 instead? Is the 2 below 'Factor'? If so it would be good to use the variable name or a clear explanation of what it is.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69392/new/

https://reviews.llvm.org/D69392





More information about the llvm-commits mailing list