[PATCH] D69665: [llvm-ar] Fix llvm-ar response file reading on Windows

[Owen Reynolds via Phabricator via llvm-commits]

gbreynoo marked an inline comment as done.
gbreynoo added inline comments.


================
Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:1095
+                              ? cl::TokenizeWindowsCommandLine
+                              : cl::TokenizeGNUCommandLine,
+                          Argv);
----------------
thakis wrote:
> If we do this, we almost certainly want to add an --rsp-quoting flag like clang-cl and lld-link have, for cross builds targeting windows on linux.
I agree that flag would be useful but that it should be in another diff. I think that this change is useful by itself and could be committed first.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69665/new/

https://reviews.llvm.org/D69665