[PATCH] D68267: [MBB LiveIn lists, MachineVerifier, SystemZ] New method isLiveOut() and mverifier improvement.

Jonas Paulsson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 4 05:37:22 PST 2019


jonpa updated this revision to Diff 227698.
jonpa added a comment.

> In principle, yes -- however, it seems to be an unrelated change, so it should probably be a separate commit. Also, I don't see why we need a global LivePhysReg variable here, this should really be local to processBlock.

OK, I can commit the SystemZ changes separately. Changed SystemZElimCompare.cpp to use LivePhysReg locally.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68267/new/

https://reviews.llvm.org/D68267

Files:
  llvm/include/llvm/CodeGen/LivePhysRegs.h
  llvm/lib/CodeGen/MachineVerifier.cpp
  llvm/lib/Target/SystemZ/SystemZElimCompare.cpp
  llvm/test/MachineVerifier/live-ins-01.mir
  llvm/test/MachineVerifier/live-ins-02.mir
  llvm/test/MachineVerifier/live-ins-03.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68267.227698.patch
Type: text/x-patch
Size: 7438 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191104/b8df8981/attachment.bin>


More information about the llvm-commits mailing list