[PATCH] D68420: Fix PR40644: miscompile indexed FP constant store

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 4 04:02:57 PST 2019


thopre added a comment.

In D68420#1694954 <https://reviews.llvm.org/D68420#1694954>, @thopre wrote:

> In D68420#1693679 <https://reviews.llvm.org/D68420#1693679>, @lebedev.ri wrote:
>
> > Tests missing.
>
>
> We've met this bug with an out of tree target. It requires a target with truncating or indexed constant float store which Eli Friedman was of the opinion is not the case of any of the in tree target. Still the change is small and obvious enough to be accepted. Both of these functions proceed with doing a regular integer store regardless of the initial store.


Ping?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68420/new/

https://reviews.llvm.org/D68420





More information about the llvm-commits mailing list